Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nginx template #290

Merged
merged 1 commit into from
Sep 16, 2020
Merged

Conversation

neolyte
Copy link
Contributor

@neolyte neolyte commented Oct 31, 2019

Update Nginx template:

@seuros
Copy link
Owner

seuros commented Sep 16, 2020

I think http2 should be default now. Do you want to update your PR ?

@neolyte
Copy link
Contributor Author

neolyte commented Sep 16, 2020

I think http should be default now. Do you want to update your PR ?

I'm not sure I understand what you mean. Which http default are you referring to?

@seuros
Copy link
Owner

seuros commented Sep 16, 2020

Sorry i meant let default to listen 443 ssl http2;

@neolyte
Copy link
Contributor Author

neolyte commented Sep 16, 2020

You're right - this should be all good now !

@seuros
Copy link
Owner

seuros commented Sep 16, 2020

Awesome
can you squash your commits ? The 2 first ones don't have your name/email.

…option to enable http2 for nginx with ssl - make it default to true.
@neolyte neolyte force-pushed the update-nginx-template branch from 2d66005 to 7844160 Compare September 16, 2020 08:55
@neolyte
Copy link
Contributor Author

neolyte commented Sep 16, 2020

Is that better now?

@seuros seuros merged commit b148515 into seuros:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants