Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed call parameter #280

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Fixed call parameter #280

merged 1 commit into from
Mar 20, 2019

Conversation

stefanwild
Copy link
Contributor

Config files were not read due to a typo in the (or possibly outdated) command line parameters.

@seuros seuros merged commit acbadc8 into seuros:master Mar 20, 2019
@ViliusLuneckas
Copy link

Hi @stefanwild, @seuros, is it a valid fix?

Regarding help message in Puma::ControlCli, config must be specified after -F parameter, not the -C.

opts = OptionParser.new do |o|
  o.banner = "Usage: pumactl (-p PID | -P pidfile | -S status_file | -C url -T token | -F config.rb) (#{COMMANDS.join("|")})"

https://github.com/puma/puma/blob/6e7d38540ffada91355498c9abe0c98f1d22b9e1/lib/puma/control_cli.rb#L32

@stefanwild
Copy link
Contributor Author

stefanwild commented Apr 9, 2019

@ViliusLuneckas, you're absolutely right. I have no idea what happened here. I tested this numerous times and looked up documentation before submitting the PR. This actually breaks the call and should be reversed. I apologize!

@stefanwild
Copy link
Contributor Author

It looks like I confused puma (for which the config file parameter is -C) and pumactl (for which the config file parameter is -F). Again, apologies for breaking this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants