Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Install Buffers to each configuration #78

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

Eltord
Copy link
Contributor

@Eltord Eltord commented Jul 14, 2023

Created new variables to each configuration for install buffers

Added the calculation to add buffer to estimated time for presenting to user

@drtaru
Copy link
Contributor

drtaru commented Jul 14, 2023

Hey Eltord,

This is already what the correctionCoeficcient value on #L135 does, if you look starting on #L2251 the size is multiplied by the coefficient to inflate the value. Simply increase the correctionCoefficient value to pad the install time.

@Eltord
Copy link
Contributor Author

Eltord commented Jul 14, 2023

So with some work I was still unable to get the desired results with the correctionCoeficcient value as the different configurations required different "fudge factors", so at a minimum the factors would need a different value per configuration. I've discussed this in an FR I put in previously for this as well.

@dan-snelson dan-snelson self-assigned this Jul 14, 2023
@dan-snelson dan-snelson added this to the 1.12.0 milestone Jul 14, 2023
dan-snelson added a commit that referenced this pull request Jul 31, 2023
Added Install Buffers to each configuration #78
@dan-snelson dan-snelson merged commit b5bfdc9 into setup-your-mac:1.12.0 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants