Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check bannerImage & welcomeBannerImage #21

Closed
wants to merge 2 commits into from
Closed

check bannerImage & welcomeBannerImage #21

wants to merge 2 commits into from

Conversation

amadotejada
Copy link
Contributor

The Dialog fails to open if the banner/welcome images are not available. We use this to test the image URLs and set an alternative image if the default fails. Folks can add a second custom image as a backup.

@dan-snelson
Copy link
Collaborator

dan-snelson commented Apr 7, 2023 •
edited
Loading

Thanks, @amadotejada.

swiftDialog/swiftDialog#239

swiftDialog/swiftDialog#217

dan-snelson
dan-snelson reviewed Apr 7, 2023
View reviewed changes
Copy link
Collaborator

@dan-snelson dan-snelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amadotejada:

The development branch is now at 1.10.0-rc4; will you please update your side to this version and re-submit?

Thanks.

--
Dan

Setup-Your-Mac-via-Dialog.bash Outdated Show resolved Hide resolved
Setup-Your-Mac-via-Dialog.bash Outdated Show resolved Hide resolved
Setup-Your-Mac-via-Dialog.bash Outdated Show resolved Hide resolved
Setup-Your-Mac-via-Dialog.bash Outdated Show resolved Hide resolved
@dan-snelson dan-snelson self-assigned this Apr 7, 2023
@dan-snelson dan-snelson added enhancement New feature or request good first issue Good for newcomers waiting feedback Waiting on feedback from requestor labels Apr 7, 2023
@dan-snelson dan-snelson added this to the 1.10.0 milestone Apr 7, 2023
@amadotejada
Copy link
Contributor Author

@dan-snelson

Updated to 1.10.0-rc4 and replaced the echo lines.

Thank you

@dan-snelson dan-snelson removed the waiting feedback Waiting on feedback from requestor label Apr 8, 2023
dan-snelson
dan-snelson requested changes Apr 8, 2023
View reviewed changes
Copy link
Collaborator

@dan-snelson dan-snelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amadotejada:

Perhaps it's me, but it appears that this is still committed against 1.9.0:

https://github.com/amadotejada/Setup-Your-Mac/blob/647241c9c263adf7ef7eca582390137bf7a25b74/Setup-Your-Mac-via-Dialog.bash#L36

@dan-snelson dan-snelson added the waiting feedback Waiting on feedback from requestor label Apr 8, 2023
@amadotejada amadotejada mentioned this pull request Apr 8, 2023
Merged
@dan-snelson
Copy link
Collaborator

Closing; see Pull No. 22.

@dan-snelson dan-snelson closed this Apr 8, 2023
@amadotejada amadotejada deleted the get-alternate-banners branch April 20, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-snelson dan-snelson dan-snelson requested changes

Assignees

@dan-snelson dan-snelson

Labels
enhancement New feature or request good first issue Good for newcomers waiting feedback Waiting on feedback from requestor
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@amadotejada @dan-snelson