Fix up linting tools (#21)

.github/workflows/test.yml

@@ -11,25 +11,85 @@ on:
     - main
 
 jobs:
-  test:
-    runs-on: ubuntu-latest
+  lint:
+    runs-on: 'ubuntu-latest'
 
     steps:
-    - uses: actions/checkout@v2
+    - uses: 'actions/checkout@v3'
 
-    - uses: actions/setup-go@v2
+    - uses: 'actions/setup-go@v3'
       with:
         go-version: '1.14'
 
-    - uses: actions/cache@v2
+    - uses: 'golangci/golangci-lint-action@v3'
       with:
-        path: ~/go/pkg/mod
-        key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-        restore-keys: |
-          ${{ runner.os }}-go-
+        version: 'v1.50.1'
+        only-new-issues: true
+        skip-cache: true
+        skip-pkg-cache: true
+        skip-build-cache: true
+        args: >-
+          --enable=${{ join(fromJson('[
+            "asciicheck",
+            "bidichk",
+            "bodyclose",
+            "containedctx",
+            "depguard",
+            "dogsled",
+            "errcheck",
+            "errchkjson",
+            "errname",
+            "errorlint",
+            "exhaustive",
+            "exportloopref",
+            "forcetypeassert",
+            "godot",
+            "gofumpt",
+            "goheader",
+            "goimports",
+            "gomodguard",
+            "goprintffuncname",
+            "gosec",
+            "gosimple",
+            "govet",
+            "ifshort",
+            "ineffassign",
+            "makezero",
+            "noctx",
+            "nolintlint",
+            "prealloc",
+            "predeclared",
+            "revive",
+            "sqlclosecheck",
+            "staticcheck",
+            "stylecheck",
+            "tenv",
+            "thelper",
+            "tparallel",
+            "typecheck",
+            "unconvert",
+            "unused",
+            "whitespace",
+          ]'), ',') }}
+          --max-issues-per-linter=0
+          --max-same-issues=0
+          --timeout=5m
+
+  test:
+    strategy:
+      matrix:
+        platform:
+        - 'macos-latest'
+        - 'ubuntu-latest'
+        - 'windows-latest'
+
+    runs-on: '${{ matrix.platform }}'
 
-    - name: Lint
-      run: make fmtcheck staticcheck spellcheck
+    steps:
+    - uses: 'actions/checkout@v3'
+
+    - uses: 'actions/setup-go@v3'
+      with:
+        go-version: '1.14'
 
-    - name: Test
-      run: make test-acc
+    - run: 'make test-acc'

.golangci.yml

@@ -0,0 +1,119 @@
+run:
+  # default: '1m'
+  timeout: '5m'
+
+  # default: []
+  build-tags: []
+
+  # default: ''
+  modules-download-mode: 'readonly'
+
+  # default: false
+  allow-parallel-runners: true
+
+linters:
+  enable:
+  - 'asasalint'
+  - 'asciicheck'
+  - 'bidichk'
+  - 'bodyclose'
+  - 'containedctx'
+  - 'contextcheck'
+  - 'cyclop'
+  - 'decorder'
+  - 'depguard'
+  - 'dogsled'
+  - 'dupl'
+  - 'dupword'
+  - 'durationcheck'
+  - 'errcheck'
+  - 'errchkjson'
+  - 'errname'
+  - 'errorlint'
+  - 'execinquery'
+  - 'exhaustive'
+  - 'exhaustruct'
+  - 'exportloopref'
+  - 'forbidigo'
+  - 'forcetypeassert'
+  - 'funlen'
+  - 'gci'
+  - 'gochecknoglobals'
+  - 'gochecknoinits'
+  - 'gocognit'
+  - 'goconst'
+  - 'gocritic'
+  - 'gocyclo'
+  - 'godot'
+  - 'godox'
+  - 'goerr113'
+  - 'gofumpt'
+  - 'goheader'
+  - 'goimports'
+  - 'gomnd'
+  - 'gomoddirectives'
+  - 'gomodguard'
+  - 'goprintffuncname'
+  - 'gosec'
+  - 'gosimple'
+  - 'govet'
+  - 'grouper'
+  - 'importas'
+  - 'ineffassign'
+  - 'interfacebloat'
+  - 'ireturn'
+  - 'lll'
+  - 'loggercheck'
+  - 'maintidx'
+  - 'makezero'
+  - 'misspell'
+  - 'nakedret'
+  - 'nestif'
+  - 'nilerr'
+  - 'nilnil'
+  - 'nlreturn'
+  - 'noctx'
+  - 'nolintlint'
+  - 'nonamedreturns'
+  - 'nosprintfhostport'
+  - 'paralleltest'
+  - 'prealloc'
+  - 'predeclared'
+  - 'promlinter'
+  - 'reassign'
+  - 'revive'
+  - 'rowserrcheck'
+  - 'sqlclosecheck'
+  - 'staticcheck'
+  - 'stylecheck'
+  - 'tagliatelle'
+  - 'tenv'
+  - 'testableexamples'
+  - 'testpackage'
+  - 'thelper'
+  - 'tparallel'
+  - 'typecheck'
+  - 'unconvert'
+  - 'unparam'
+  - 'unused'
+  - 'usestdlibvars'
+  - 'varnamelen'
+  - 'wastedassign'
+  - 'whitespace'
+  - 'wrapcheck'
+  - 'wsl'
+
+issues:
+  # default: []
+  exclude:
+  - '^SA3000:' # staticcheck: not required in Go 11.4+
+
+  # default: 50
+  max-issues-per-linter: 0
+
+  # default: 3
+  max-same-issues: 0
+
+severity:
+  # default: ''
+  default-severity: error