Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move in wr-replay #495

Closed
kvark opened this issue Oct 28, 2016 · 1 comment
Closed

Move in wr-replay #495

kvark opened this issue Oct 28, 2016 · 1 comment

Comments

@kvark
Copy link
Member

kvark commented Oct 28, 2016

https://github.com/kvark/wr-replay
Could live in this repo as a binary.
Would increase the discover-ablitiy, make sure the code is up to date.
Related - #494

@kvark
Copy link
Member Author

kvark commented Oct 31, 2016

I've been messing with the move process and faced a few issues:

  1. While I can preserve the source history, I don't think Cargo.toml one needs to be saved
  2. Too bad the webrender is in a sub-dir of the crate, since the binary would need to be as far as webrender/src/bin/replay.rs now
  3. Cargo doesn't support binary-only dependencies (Allow dependencies that only apply to specific cargo targets (bin, example, etc.) rust-lang/cargo#1982), and so it's unclear how to properly depend on glutin for this binary. One way is to make it an "example", but this doesn't sound good to me.

bors-servo pushed a commit that referenced this issue Oct 31, 2016
Moving in the replay tool

Closes #495

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/504)
<!-- Reviewable:end -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant