Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix](stylo): Fix "bare CR not allowed in doc-comment" windows #123

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d-desiatkin
Copy link

In case of building servo on Windows platform; Specifically after the following PR: #122
I keep getting following error message: "bare CR not allowed in doc-comment".
Changes bellow helped me to resolve the problem

of building servo on Windows platform

Signed-off-by: Desiatkin Dmitrii <d.desyatkin@innopolis.university>
@Loirooriol
Copy link
Contributor

So apparently, without newline='', f.write will convert newlines to the default line separator on that OS?

I guess Firefox is affected too? May be better to fix it upstream and then it will be imported here.

@d-desiatkin
Copy link
Author

d-desiatkin commented Feb 13, 2025

So apparently, without newline='', f.write will convert newlines to the default line separator on that OS?

I guess Firefox is affected too? May be better to fix it upstream and then it will be imported here.

Yes. Exactly like that.
It would be nice if someone could reproduce the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants