Preserve port and user/pass info for path-based resources #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! This looks much nicer. Just need to fix protocol relative URLs and it'll be good to go. |
|
For some reason associated "//..." with same host. Should be fixed now with a new test. |
|
Thanks, @dhedlund! So many awesome PRs. |
bors-servo
pushed a commit
that referenced
this pull request
Dec 10, 2013
User credentials and port were not being preserved when pre-fetching path-based resources. For example, consider the following HTML:
```html
<html>
<body>
<img src="logo.png" />
</body>
```
Running the following command would try to fetch the image from `http://localhost/my-site/logo.png` and crash the browser with ConnectionRefused error:
```
$ ./servo http://foo:bar@localhost:8080/my-site/
task '<unnamed>' failed at 'Unhandled condition: io_error: rt::io::IoError{kind: ConnectionRefused, desc: "connection refused", detail: None}', /home/daniel/Programming/servo/src/compiler/rust/src/libstd/condition.rs:131
...
```
This should now be fixed.
|
rust-lang/rust#10707 is relevant (but not blocking). I’d like to replace |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User credentials and port were not being preserved when pre-fetching path-based resources. For example, consider the following HTML:
Running the following command would try to fetch the image from
http://localhost/my-site/logo.pngand crash the browser with ConnectionRefused error:This should now be fixed.