Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-special URLs can have their paths erased #919

Closed
wants to merge 0 commits into from

Conversation

DylanOToole2
Copy link
Contributor

@DylanOToole2 DylanOToole2 commented Apr 1, 2024

For Bug 1874117 with reviewer @valenting

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@73803fa). Click here to learn what that means.

❗ Current head 3ded72a differs from pull request most recent head 966b417. Consider uploading reports for the commit 966b417 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #919   +/-   ##
=======================================
  Coverage        ?   81.79%           
=======================================
  Files           ?       20           
  Lines           ?     3553           
  Branches        ?        0           
=======================================
  Hits            ?     2906           
  Misses          ?      647           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@valenting valenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. Let's just fix the lints to make CI happy

let mut path_to_set = String::from("/");
path_to_set.push_str(new_pathname);
url.set_path(&path_to_set)
}
else {
url.set_path(new_pathname)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants