Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move debugger_visualizer tests to separate crate #853

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ jobs:
if: |
matrix.os == 'windows-latest' &&
matrix.rust == 'nightly'
run: cargo test --test debugger_visualizer --features "url/serde,url/debugger_visualizer" -- --test-threads=1
run: cargo test --test debugger_visualizer --features "url/debugger_visualizer,url_debug_tests/debugger_visualizer" -- --test-threads=1
- name: Test `no_std` support
run: cargo test --no-default-features --features=alloc

Expand Down
9 changes: 8 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
@@ -1,2 +1,9 @@
[workspace]
members = ["url", "form_urlencoded", "idna", "percent_encoding", "data-url"]
members = [
"url",
"form_urlencoded",
"idna",
"percent_encoding",
"data-url",
"url_debug_tests",
]
11 changes: 1 addition & 10 deletions url/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,12 @@ appveyor = { repository = "Manishearth/rust-url" }
[dev-dependencies]
serde_json = "1.0"
bencher = "0.1"
# To test debugger visualizers defined for the url crate such as url.natvis
debugger_test = "0.1"
debugger_test_parser = "0.1"

[dependencies]
form_urlencoded = { version = "1.2.0", path = "../form_urlencoded" }
idna = { version = "0.4.0", path = "../idna" }
percent-encoding = { version = "2.3.0", path = "../percent_encoding" }
serde = {version = "1.0", optional = true, features = ["derive"]}
serde = { version = "1.0", optional = true, features = ["derive"] }

[features]
default = []
Expand All @@ -46,12 +43,6 @@ name = "parse_url"
path = "benches/parse_url.rs"
harness = false

[[test]]
name = "debugger_visualizer"
path = "tests/debugger_visualizer.rs"
required-features = ["debugger_visualizer"]
test = false

[package.metadata.docs.rs]
features = ["serde"]

Expand Down
21 changes: 21 additions & 0 deletions url_debug_tests/Cargo.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
[package]

name = "url_debug_tests"
version = "0.0.0"
description = "Tests for debugger visualizers defined for the url crate such as url.natvis"
publish = false
rust-version = "1.60"

[dev-dependencies]
url = { path = "../url" }
debugger_test = "0.1"
debugger_test_parser = "0.1"

[features]
debugger_visualizer = []

[[test]]
name = "debugger_visualizer"
path = "tests/debugger_visualizer.rs"
required-features = ["debugger_visualizer"]
test = false
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
extern crate debugger_test;
extern crate url;

use debugger_test::debugger_test;
use url::Url;

Expand Down