Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made rust-url compile with rust master #1

Merged
merged 1 commit into from
Apr 9, 2014
Merged

Conversation

dmski
Copy link
Contributor

@dmski dmski commented Apr 9, 2014

No description provided.

SimonSapin added a commit that referenced this pull request Apr 9, 2014
Made rust-url compile with rust master
@SimonSapin SimonSapin merged commit 350bd6b into servo:master Apr 9, 2014
@SimonSapin
Copy link
Member

Looks good, thanks!

In what context are you using rust-url? Any feedback on the API or feature set or something is appreciated.

@dmski
Copy link
Contributor Author

dmski commented Apr 10, 2014

I'm working on an app that'll handle audio streams, and i'll have to store urls of the said streams somewhere and sometimes extract parts of those urls (scheme, host/port, path and fragment). One reason for me not to use rustc's liburl is that i'm very likely to get urls with unicode in them, which liburl has some problems with (rust-lang/rust#8486).

I don't have any feedback on API at the moment, since i haven't actually tried to write that part yet. I'll submit issues/PRs here if/when i do have some feedback, if that's ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants