Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport MaybeUninit changes to 0.6 #180

Merged
merged 3 commits into from
Nov 5, 2019
Merged

Conversation

mbrubeck
Copy link
Collaborator

@mbrubeck mbrubeck commented Nov 4, 2019

This is a backport of #162 and #170 to the smallvec 0.6 branch. To avoid bumping the minimum Rust version, the maybe-uninit crate is used in place of std::mem::MaybeUninit. To avoid breaking changes, the Array::ptr and ptr_mut methods are retained but are no longer used, and the API to from_buf_and_len_unchecked is unchanged.

Thom Chiovoloni and others added 3 commits November 4, 2019 11:03
This is a backport of servo#162 to the smallvec 0.6 branch. To avoid bumping the
minimum Rust version, the `maybe-uninit` crate is used in place of
`std::mem::MaybeUninit`.  To avoid breaking changes, the `Array::ptr` and
`ptr_mut` methods are retained but are no longer used, and the API to
`from_buf_and_len_unchecked` is unchanged.
Works now on trunk.

Closes servo#139
Copy link
Member

@emilio emilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

@emilio emilio merged commit 7852204 into servo:0.6 Nov 5, 2019
@RalfJung
Copy link
Contributor

RalfJung commented Nov 5, 2019

Awesome, thanks. :)

What does your release schedule look like? (I exempted arrays from rust-lang/rust#66059 for now to give smallvec users some more time.)

@mbrubeck
Copy link
Collaborator Author

mbrubeck commented Nov 5, 2019

Published version 0.6.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants