This repository has been archived by the owner on Jul 10, 2023. It is now read-only.
Avoid unnecessary buffer requests #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| rect_in_window.size); | ||
|
|
||
| match layer_rect.intersection(&layer_bounds) { | ||
| redraw_rect: TypedRect<LayerPixel, f32>) { |
There was a problem hiding this comment.
Is dirty_rect a better name here?
There was a problem hiding this comment.
dirty_rect definitely works for me.
Now that layers can mask their children, we should avoid issuing buffer requests for areas outside of the mask region. At the same time, layers can now be positioned and sized so that they do not intersect with their parents at all. In those cases, we still need to issue buffer requests for the layers even if their parents do not intersect the redraw region.
zwarich
pushed a commit
that referenced
this pull request
Oct 2, 2014
Avoid unnecessary buffer requests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that layers can mask their children, we should avoid issuing buffer
requests for areas outside of the mask region. At the same time, layers
can now be positioned and sized so that they do not intersect with their
parents at all. In those cases, we still need to issue buffer requests
for the layers even if their parents do not intersect the redraw region.