More documentation #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change the description from something rustc-specific to something more general, outlining its advantages and disadvantages (and linking to graphs) - Move the important parts to the crate doc instead of the struct's doc, which makes it easier to find - Add inline Rustdoc examples for using it with HashMap and HashSet - Put the test in a module (not important, but it's what people expect to see)
|
r? @SimonSapin |
|
r=me the version number bumped to 1.0.1 to publish on crates.io, where Servo can pick it up in order to have the docs show up on doc.servo.org. |
|
@bors-servo r=SimonSapin |
|
|
I fixed the repo collaborators to address point 2. |
|
|
||
| ```toml | ||
| [dependencies] | ||
| fnv = "1.0.0" |
There was a problem hiding this comment.
I don't see any reason to bump this everytime we release a new 1.0.x release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #3 to work with stable and beta. I couldn't get
cfg_attr!()to work correctly with conditionally turning on features, so I just disabled the nightly-only tests for now.Fixes #3.