Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component-wise division for Vector2 #480

Closed
alexkirsz opened this issue Apr 12, 2021 · 2 comments
Closed

Component-wise division for Vector2 #480

alexkirsz opened this issue Apr 12, 2021 · 2 comments

Comments

@alexkirsz
Copy link

Writing this as a follow-up to #475

I think it would make sense to also have component-wise division, as well as component-wise ceiling division for integer types.

See:
@nical
Copy link
Contributor

nical commented Apr 12, 2021

Sounds good to me. If you want to make a quick PR I'll review it.

This was referenced Apr 12, 2021
Merged
Closed
@alexkirsz
Copy link
Author

@nical I created two PRs: #481 and #482

bors-servo added a commit that referenced this issue Apr 12, 2021
@bors-servo
Auto merge of #481 - alexkirsz:component_div, r=nical
e8728b4 
Add component-wise division of 2d and 3d vectors

Partial fix for #480.

See also #476 for the implementation of component_mul.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nical @alexkirsz