-
Notifications
You must be signed in to change notification settings - Fork 38
Adds an additional display function + bumps core-foundation dependency version #87
Conversation
☔ The latest upstream changes (presumably #86) made this pull request unmergeable. Please resolve the merge conflicts. |
This looks fine. Sorry for the delay; if you rebase and increase appropriate Cargo version numbers, we can merge and publish these changes. |
Done. |
The changes here don't seem like they're breaking; why did you increment the minor version number? |
They are indeed non breaking, that's why I incremented the minor version, not the major version. I incremented the minor version as I thought that changing the dependency versions (core-foundation 0.3 -> core-foundation 0.4) requires this change. But if it is not the case, I can revert this change and increase only the patch version. |
UPD. I just followed semver:
|
Ok, looks like the version bump in @bors-servo r+ |
📌 Commit f9f2226 has been approved by |
Adds an additional display function + bumps core-foundation dependency version This is a small pull request, basically it adds the following things: 1. Adds a missing `CGDisplayCreateImage()` function, so that now the user has all required functions to capture static images (it was already implemented for window capturing and now the display capturing is also possible). 2. Adds a couple functions to `CGRect`. 3. Updates the version for `core-foundation` from `0.3` to `0.4`. I'm not sure if using `0.3` makes sense if we can use `0.4`. For me personally it was required to change it as my project depends on several crates, including the latest `core-foundation` version, so when I have both `core-graphics` and `core-foundation` in my dependencies, `core-foundation` has been compiled twice (once for `0.4` which is the new version and once for the old `0.3` which has been downloaded and compiled as one of the `core-graphics` dependencies). So basically the people who use the both `core-graphics` and `core-foundation` (the last versions) would encounter the same problems (`core-foundation` is compiled twice and it may cause compile time errors like it was in my case). What are your thoughts on these? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/core-graphics-rs/87) <!-- Reviewable:end -->
☀️ Test successful - status-travis |
This follows the servo pattern mentioned in rust-lang/rust#27303 to replace the zero-sized structs with an `enum`.
Changes zero-sized structs to an `enum` and removed unused macro use statement.
This is a small pull request, basically it adds the following things:
CGDisplayCreateImage()
function, so that now the user has all required functions to capture static images (it was already implemented for window capturing and now the display capturing is also possible).CGRect
.core-foundation
from0.3
to0.4
. I'm not sure if using0.3
makes sense if we can use0.4
. For me personally it was required to change it as my project depends on several crates, including the latestcore-foundation
version, so when I have bothcore-graphics
andcore-foundation
in my dependencies,core-foundation
has been compiled twice (once for0.4
which is the new version and once for the old0.3
which has been downloaded and compiled as one of thecore-graphics
dependencies). So basically the people who use the bothcore-graphics
andcore-foundation
(the last versions) would encounter the same problems (core-foundation
is compiled twice and it may cause compile time errors like it was in my case). What are your thoughts on these?This change is