Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update production profile documentation #39

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

atbrakhi
Copy link
Member

@atbrakhi atbrakhi commented Dec 2, 2024

In 34340 we optimize production profile. This changes updates the book accordingly

In servo/servo#34340 we optimize
`production` profile. This changes update the book accordingly

Signed-off-by: atbrakhi <atbrakhi@igalia.com>
@atbrakhi atbrakhi requested a review from delan December 2, 2024 10:47
Copy link
Member

@delan delan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think in this case the details are not too important to mention explicitly, because we have the links. Can we keep the text as is and update the links?

@atbrakhi
Copy link
Member Author

atbrakhi commented Dec 2, 2024

Thanks! I think in this case the details are not too important to mention explicitly, because we have the links. Can we keep the text as is and update the links?

done in 679f242

@atbrakhi atbrakhi force-pushed the update-build-profile branch from 3d99dbb to 679f242 Compare December 2, 2024 12:16
@@ -57,7 +57,7 @@ There are three main build profiles, which you can build and use independently o
<th>optimised?
<td><a href="https://doc.rust-lang.org/cargo/reference/profiles.html#dev">no</a>
<td><a href="https://github.com/servo/servo/blob/457d37d94ee6966cad377c373d333a00c637e1ae/Cargo.toml#L153">yes</a>
<td>yes, <a href="https://github.com/servo/servo/blob/457d37d94ee6966cad377c373d333a00c637e1ae/Cargo.toml#L159-L160">more</a> <a href="https://github.com/servo/servo/blob/457d37d94ee6966cad377c373d333a00c637e1ae/Cargo.toml#L170-L171">than</a> in <strong>release</strong>
<td>yes, <a href="https://github.com/servo/servo/blob/9457a40ca2cd4b9530ba7c5334c82f3b3f2e7ac8/Cargo.toml#L177-L182">more</a> <a href="https://github.com/servo/servo/blob/9457a40ca2cd4b9530ba7c5334c82f3b3f2e7ac8/Cargo.toml#L166-L67">than</a> in <strong>release</strong>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<td>yes, <a href="https://github.com/servo/servo/blob/9457a40ca2cd4b9530ba7c5334c82f3b3f2e7ac8/Cargo.toml#L177-L182">more</a> <a href="https://github.com/servo/servo/blob/9457a40ca2cd4b9530ba7c5334c82f3b3f2e7ac8/Cargo.toml#L166-L67">than</a> in <strong>release</strong>
<td>yes, <a href="https://github.com/servo/servo/blob/9457a40ca2cd4b9530ba7c5334c82f3b3f2e7ac8/Cargo.toml#L177-L182">more than</a> in <strong>release</strong>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(the second link seems to be broken anyway)

Signed-off-by: atbrakhi <atbrakhi@igalia.com>
@atbrakhi atbrakhi force-pushed the update-build-profile branch from 679f242 to 2e53dc6 Compare December 2, 2024 12:22
@delan delan self-requested a review December 3, 2024 08:16
Copy link
Member

@delan delan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@delan delan merged commit aa0f8db into main Dec 3, 2024
@delan delan deleted the update-build-profile branch December 3, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants