Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe ./mach try and expand workflow for updating test results #38

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

simonwuelker
Copy link
Contributor

No description provided.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Release mode is not just required when running the full suite,
for example the PBKDF2 tests in WebCryptoAPI/derive_bits will
consistently time out in development mode.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Doing a full ./mach test-wpt run is really impractical,
because it takes a long time even in release mode
and causes tons of unrelated failures.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@delan
Copy link
Member

delan commented Nov 28, 2024

I will review this on Monday :)

Copy link
Member

@delan delan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few minor changes…

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@simonwuelker simonwuelker requested a review from delan December 10, 2024 00:21
Copy link
Member

@delan delan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just the source formatting now.

Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
@delan delan merged commit 4fcfe2c into servo:main Dec 11, 2024
@simonwuelker simonwuelker deleted the testing-updates branch December 11, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants