Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes "editor not found" errors in the Dashboard #483

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Conversation

JBBianchi
Copy link
Member

Many thanks for submitting your Pull Request ❤️!

What this PR does / why we need it:
Aligned Blazor application state with DOM state to prevent issues like 'Couldn't find the editor with id...' or 'Editor with ID "..." not found'.

Special notes for reviewers:

Additional information (if needed):

Aligned Blazor application state with DOM state to prevent issues like
'Couldn't find the editor with id...' or 'Editor with ID "..." not found'.

Signed-off-by: Jean-Baptiste Bianchi <jb.bianchi@neuroglia.io>
@JBBianchi JBBianchi added type: bug Something isn't working app: dashboard Concerns the Dashboard UI priority: medium Indicates an average priority issue weight: 1 An issue that has a very low development impact type: fix labels Jan 22, 2025
@JBBianchi JBBianchi added this to the v1.0.0 milestone Jan 22, 2025
@JBBianchi JBBianchi requested a review from cdavernas January 22, 2025 15:29
@JBBianchi JBBianchi self-assigned this Jan 22, 2025
Copy link
Member

@cdavernas cdavernas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks man ❤️

@cdavernas cdavernas merged commit 9855378 into main Jan 22, 2025
2 checks passed
@cdavernas cdavernas deleted the fix-monaco-bug branch January 22, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: dashboard Concerns the Dashboard UI priority: medium Indicates an average priority issue type: bug Something isn't working type: fix weight: 1 An issue that has a very low development impact
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants