-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix windows symlink creation #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested with Window 10 in Developper Mode, with Node 8.12, serverless@1.31.0 / serverless-plugin-typescript@1.1.5, running the shell in Administrator mode, and it worked.
Hope this will be merged some day 🤞 |
Yeah, @schickling if you have any news about that. In the meantime, I'm forking this with your patch @LadnovSasha |
Fix windows symlink creation serverless#109
Can someone please pull this in because it's causing me issues. |
The change to index.js when done manually to files for version 1.1.5 is working properly on Windows 10. |
I fixed it by using When will this be merged...? |
For anyone who takes in |
Please pull this, it solves the problem(as long as you run it as admin at least)... (i've testede the ThomasVuillaume/serverless-plugin-typescript#master version) |
Please could this get accepted as having to do a work around using another package forked from this. |
Seems Prisma doesn't like Windows devs :D (Psst, i've got a Linux too) |
I've published fork to npm, if someoune interested https://github.com/LadnovSasha/serverless-plugin-typescript |
Using a fork for such a "small" and easy-to-fix issue is not an adequate solution for me. :/ Edit: But since this project seems to be unmaintained anyway, it's maybe the only solution. |
@jonasduever you can see in #130 that pr is still present |
Not a lot of responses from prisma, I will try their slack channel. If not will fork and publish as a new serverless plugin thats actually updated! |
Ok we'll wait for your info |
.. is this still outstanding? I'm seeing this issue currently. |
Should fix #23, #89 , #100
According to the docs on windows we should define symlink type
Due to inactivity I am closing this PR because it goes from master (i am planning to publish it), instead I've created the same pull request in #109
Fork with fixes published here: https://github.com/LadnovSasha/serverless-plugin-typescript