You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified response status codes from 400 to 409 for POST requests for event types, functions, subscriptions and CORS configs resources. Updated unit tests and API docs accordingly.
How did you implement it:
How can we verify it:
Todos:
I'm not sure if a test for createSubscription in httpapi.go should be added in scope of the task
Write tests
Write documentation
Fix linting errors
Make sure code coverage hasn't dropped
Provide verification commands / resources
Enable "Allow edits from maintainers" for this PR
Update the messages below
Is this ready for review?: NO Is it a breaking change?: NO
I don't see anything like that in my account, unfortunately.
I checked https://travis-ci.org/serverless/event-gateway/requests, and I can see my PR failing with "Build type disabled via repository settings (pull_request)". Could this be related?
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What did you implement:
Modified response status codes from 400 to 409 for POST requests for event types, functions, subscriptions and CORS configs resources. Updated unit tests and API docs accordingly.
How did you implement it:
How can we verify it:
Todos:
I'm not sure if a test for
createSubscription
inhttpapi.go
should be added in scope of the taskIs this ready for review?: NO
Is it a breaking change?: NO