This repository has been archived by the owner on Dec 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
+ Coverage 63.89% 65.38% +1.48%
==========================================
Files 29 32 +3
Lines 1601 1788 +187
==========================================
+ Hits 1023 1169 +146
- Misses 536 573 +37
- Partials 42 46 +4
Continue to review full report at Codecov.
|
RaeesBhatti
approved these changes
May 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
This PR introduces Event Type concept to EG. It allows registering event types that can be consumed by function in a space.
Event types API is an API that allows defining event types on per space basis. Every event emitted to a space has to have type registered beforehand. If there is no event type registered an error is returned by Events API.
Todos:
Is this ready for review?: YES
Is it a breaking change?: YES