Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue that the KIE configuration fails to be delivered and the configuration of the tag-transmission plugin fails to be queried #1557

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

hanbingleixue
Copy link
Collaborator

@hanbingleixue hanbingleixue commented Jun 26, 2024

What type of PR is this?

Bug

What this PR does / why we need it?

1、Fix the issue where the configuration of tag-transmission fails to be queried.
2、Fixed the issue that the prompt message is incorrect when the configuration management switch is turned off.
3、Fix the issue that KIE configurations fail to be delivered.

Which issue(s) this PR fixes?

Fixes #1543

Does this PR introduce a user-facing change?

No

Checklist

  • Make sure there is a GitHub_issue related with this PR before you start working on it.
  • Make sure you have squashed your change to one single commit.
  • GitHub Actions works fine in this PR.

@hanbingleixue hanbingleixue changed the title Fix issues encountered during testing Fixed the issue that the KIE configuration fails to be delivered and the configuration of the tag-transmission plugin fails to be queried Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 28 lines in your changes missing coverage. Please review.

Flag Coverage Δ Complexity Δ
unittests 42.93% <20.00%> (-0.03%) 181.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ Complexity Δ
...va/io/sermant/implement/utils/LabelGroupUtils.java 55.35% <100.00%> (+1.65%) 0.00 <0.00> (ø)
.../sermant/backend/entity/config/ResultCodeType.java 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
.../io/sermant/backend/common/conf/DynamicConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ice/dynamicconfig/kie/KieDynamicConfigService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...ervice/dynamicconfig/kie/client/kie/KieClient.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...java/io/sermant/backend/service/ConfigService.java 28.08% <0.00%> (-1.21%) 0.00 <0.00> (ø)
...rvice/dynamicconfig/zookeeper/ZooKeeperClient.java 24.24% <0.00%> (-0.45%) 0.00 <0.00> (ø)

... and 29 files with indirect coverage changes

@hanbingleixue hanbingleixue force-pushed the develop branch 2 times, most recently from 0858d10 to 68ece55 Compare June 27, 2024 03:05
lilai23
lilai23 previously approved these changes Jun 27, 2024
lilai23
lilai23 previously approved these changes Jun 27, 2024
Signed-off-by: hanbingleixue <hanbingleixue@hotmail.com>
@Sherlockhan Sherlockhan merged commit 08d5255 into sermant-io:develop Jun 28, 2024
280 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Configuration Management function test problems
4 participants