This repository has been archived by the owner on May 25, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inyono
force-pushed
the
feature/format
branch
2 times, most recently
from
November 2, 2018 10:36
7c56277
to
4ee24ca
Compare
Knorrke
suggested changes
Nov 2, 2018
inyono
force-pushed
the
feature/format
branch
from
November 6, 2018 16:38
4ee24ca
to
70aeca2
Compare
@Knorrke Apart from the CI / lint stuff, this is done now |
Knorrke
approved these changes
Nov 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great, do you want to fix the failing travis builds before merge?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds code formatters for most of the languages used in the projects (except Twig since I didn't find a good code formatter).
Please code review
and scan b708849 to check if you are okay with coding changes introduced by php-cs-fixer.
Changelog
Added
package.json
so that we can useyarn
as task runnerstart
that executesdocker-compose up
format:prettier
that executes prettier (formats Markdown, YAML, JSON, etc.)format:php
that executes php-cs-fixer (formats PHP according to PSR-2 with some additional rules)TODO
yarn lint
that checks if files are formatted according to prettier / php-cs-fixer configyarn lint
in CI