Skip to content
This repository has been archived by the owner on May 25, 2020. It is now read-only.

Code formatting #785

Merged
merged 9 commits into from
Nov 7, 2018
Merged

Code formatting #785

merged 9 commits into from
Nov 7, 2018

Conversation

inyono
Copy link
Member

@inyono inyono commented Oct 31, 2018

This PR adds code formatters for most of the languages used in the projects (except Twig since I didn't find a good code formatter).

Please code review

and scan b708849 to check if you are okay with coding changes introduced by php-cs-fixer.

Changelog

Added

  • Add package.json so that we can use yarn as task runner
  • Add yarn script start that executes docker-compose up
  • Add yarn script format:prettier that executes prettier (formats Markdown, YAML, JSON, etc.)
  • Add yarn script format:php that executes php-cs-fixer (formats PHP according to PSR-2 with some additional rules)

TODO

  • Update changelog
  • Add yarn lint that checks if files are formatted according to prettier / php-cs-fixer config
  • Execute yarn lint in CI

@inyono inyono requested a review from Knorrke October 31, 2018 14:53
@inyono inyono force-pushed the feature/format branch 2 times, most recently from 7c56277 to 4ee24ca Compare November 2, 2018 10:36
src/module/Common/src/Common/Filter/Shortify.php Outdated Show resolved Hide resolved
src/module/Common/src/Common/Filter/Shortify.php Outdated Show resolved Hide resolved
HOWTOS.md Outdated Show resolved Hide resolved
@inyono
Copy link
Member Author

inyono commented Nov 6, 2018

@Knorrke Apart from the CI / lint stuff, this is done now

Copy link
Member

@Knorrke Knorrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great, do you want to fix the failing travis builds before merge?

@inyono inyono merged commit 3b09765 into development Nov 7, 2018
@inyono inyono deleted the feature/format branch November 7, 2018 13:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants