This repository has been archived by the owner on May 25, 2020. It is now read-only.
speed up recycle bin and sort by timestamp #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inyono
suggested changes
Oct 16, 2018
| @@ -1,20 +1,24 @@ | |||
| <?php echo $this->pageHeader('Uuid recycle bin')->render(); ?> | |||
| <?php echo $this->pageHeader('Uuid recycle bin')->setSubtitle($this->translate('Page') . $this->elements->getCurrentPageNumber())->render(); ?> | |||
There was a problem hiding this comment.
missing space between Page and current page number :)
| * <code> | ||
| * $uuids = $um->findByTrashed(true); | ||
| * foreach($uuids as $uuid) | ||
| * $elements = $um->findTrashed(); |
There was a problem hiding this comment.
Suggested change
| * $elements = $um->findTrashed(); | |
| * $elements = $um->findTrashed($page); |
inyono
reviewed
Oct 17, 2018
| @@ -1,20 +1,24 @@ | |||
| <?php echo $this->pageHeader('Uuid recycle bin')->render(); ?> | |||
| <?php echo $this->pageHeader('Uuid recycle bin')->setSubtitle($this->translate('Page') . $this->elements->getCurrentPageNumber())->render(); ?> | |||
There was a problem hiding this comment.
Suggested change
| <?php echo $this->pageHeader('Uuid recycle bin')->setSubtitle($this->translate('Page') . $this->elements->getCurrentPageNumber())->render(); ?> | |
| <?php echo $this->pageHeader('Uuid recycle bin')->setSubtitle($this->translate('Page') . ' ' . $this->elements->getCurrentPageNumber())->render(); ?> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use paginator, so fewer elements get normalized (speeding up page load time) - closes #756
Also sorting by timestamp for more convenient access to currently deleted elements.