-
-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQUEST] Support for DNS lookup during scan #105
Comments
Good idea 👍🏼
Why that? My first thought was to make a DNS request when the device is Unknown. |
I've added this. When the device is "Unknown" it will perform a reverse dns lookup. I can't specify the dns server in go, so it will use the default system dns server. For docker containers the dns can be changed like this: https://github.com/seriousm4x/UpSnap/blob/master/docker-compose.yml#L16-L18 |
When scanning something like /24, anything that doesnt have device shows as "Unknown" for me. While addresses that do have a device show up with the devics manufacturer name. 🤔 |
So your table shows every IP address in the range? |
I can confirm what gaby comments:
Can we add the two columns? Hostname for DNS Hostname and MAC Vendor for MAC Vendor? For example: Hostname | IP | MAC Address | MAC Vendor | Netmask This will be more easy to identify devices from the their DNS lookups although those devices who do not have a MAC Vendor. I test how Angry IP Scanner show MAC Vendor for devices with no real device (virtual devices) and shows it as: [n/a]. I think this is ok, because they are non real devices. |
I like this idea, that's exactly the behavior i am seeing after doing a /24 scan |
Great idea. Here is how I choose the device name now:
This will also eliminate all "Unknown" device names. Mac vendor can still show as unknown, but thats not relevant. |
Yeah that should cover all the use cases :-) I like it! |
Fantastic! :-) |
Beta build is done. Tell me if it's fixed :) |
The problem you currently have with this project
After scanning a /24 with +20 devices they all show up with the same name on the UI. It would be very useful if we could specify one or many DNS servers to find the Name of each device using it's ipv4 address
Describe the solution you'd like
Add a flag or settings option to use a DNS server to convert use the IPv4 address of the device to do a DNS lookup and use that Name when adding the device. This should only apply to devices that have both a ipv4/ipv6 address AND the name is not "Unknown"
The text was updated successfully, but these errors were encountered: