Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: unify naming pattern for containers #309

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

huxuan
Copy link
Member

@huxuan huxuan commented Feb 6, 2024

Previously, we use a single repository and differentiated containers solely based on tags. Taking project versions into consideration has made this approach more complicated. Here we unify the containers naming pattern into three categories:

  • ghcr.io/serious-scaffold/ss-python:py3.12 for production image.
  • ghcr.io/serious-scaffold/ss-python/dev:py3.12 for development image.
  • ghcr.io/serious-scaffold/ss-python/dev-cache:py3.12 for build cache of development image.

In the furture, when we have build cache of production image, we can still leverage the similar pattern.


📚 Documentation preview 📚: https://ss-python--309.org.readthedocs.build/en/309/

@huxuan huxuan marked this pull request as draft February 6, 2024 09:06
@huxuan huxuan force-pushed the xuan.hu/container-hierarchy branch from 067c8ab to 867f4a9 Compare February 6, 2024 09:12
@huxuan huxuan marked this pull request as ready for review February 6, 2024 11:55
@huxuan huxuan force-pushed the xuan.hu/container-hierarchy branch from 7a54850 to f03340b Compare February 6, 2024 11:55
@huxuan huxuan changed the title chore: Unify containers naming pattern. chore: Unify naming pattern for containers. Feb 6, 2024
@huxuan huxuan requested a review from msclock February 7, 2024 01:35
@huxuan huxuan force-pushed the xuan.hu/container-hierarchy branch from f03340b to f546bc3 Compare February 7, 2024 16:27
@huxuan huxuan changed the title chore: Unify naming pattern for containers. chore: unify naming pattern for containers Feb 7, 2024
@huxuan huxuan merged commit 7716738 into serious-scaffold:main Feb 7, 2024
8 of 9 checks passed
@huxuan huxuan deleted the xuan.hu/container-hierarchy branch February 7, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants