Fix level casing when length set to 5 and more #135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps we should pull in the version we use in Serilog? It's had bake time that we might benefit from: https://github.com/serilog/serilog/blob/dev/src/Serilog/Formatting/Display/LevelOutputFormat.cs |
|
Ah and I see the other version appears to avoid those allocations 👍 |
|
OK but I would copy added tests into #137 |
nblumhardt
added a commit
to nblumhardt/serilog-sinks-console
that referenced
this pull request
Feb 3, 2023
|
Done, thanks @sungam3r |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #76
#76 (comment) - @nblumhardt yes, fix is rather simple.
Also I would like to note that all that formatting code jumping around strings can be rewritten to allocate less memory. In ideal
GetLevelMonikershould not allocate at all. It's not hard - just to add additional entries into 3 tables insideLevelOutputFormat. I do not know why it was not done before.