-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature idea: strategy for when the queue is full #20
Comments
I think this would be a great addition to the sink. It should be enough to represent it with a I'm not likely to pick this up in the short term, but can help with a PR if anyone decides to take it on. |
@nblumhardt I'll have a crack at this one. I also noticed there doesn't seem to be a test for the existing 'drop' behaviour, so I'll try to add tests for both the 'drop' and 'block' strategies. The |
@nblumhardt I submitted PR #21 for this |
Fulfills #20 - add option to block when the queue is full, instead of dropping events
@cocowalla I'm going to go out on a limb and declare this Done Done ;) |
At present, the
BackgroundWorkerSink
will drop messages when the queue is full. It would be good to be able to configure this behaviour so there is an option to block instead of drop.The text was updated successfully, but these errors were encountered: