Updates for Serilog 4 #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
|
Has a couple of nullability warnings to fix: |
Closed
Numpsy
commented
Jul 3, 2024
| @@ -56,7 +56,7 @@ public void Configure(LoggerConfiguration loggerConfiguration) | |||
| else | |||
| { | |||
| settings = ConfigurationManager.AppSettings.AllKeys | |||
| .Select(k => new KeyValuePair<string, string>(k, ConfigurationManager.AppSettings[k])); | |||
| .Select(k => new KeyValuePair<string, string>(k, ConfigurationManager.AppSettings[k]!)); | |||
There was a problem hiding this comment.
The ! here is going on the assumption that there will always be a value for a specified key, when the key in question is from AllKeys
|
Looks great 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The System.Configuration.ConfigurationManager dependency in the .NET(Core) builds is left at 4.4.1 for now