Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add friendlyName and lowLatency to interfaces #106

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

GazHank
Copy link
Contributor

@GazHank GazHank commented Jun 20, 2023

Alternative fix for serialport/node-serialport#2600

Add friendlyName to PortInfo, and LowLatency to PortStatus

GazHank added 2 commits June 20, 2023 17:59
Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
@vercel
Copy link

vercel bot commented Jun 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 7:50am

@GazHank GazHank added the bug Something isn't working label Jun 20, 2023
Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
GazHank added 2 commits June 21, 2023 09:19
Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
@@ -27,6 +27,7 @@ interface CreatePortOptions {
manufacturer?: string;
vendorId?: string;
productId?: string;
friendlyName: string;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Required?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. Thanks for reviewing :-)

Signed-off-by: Gareth Hancock <64541249+GazHank@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

2 participants