Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update "prebuild-install" to "^7.0.0" #2359

Closed
wants to merge 1 commit into from

Conversation

zixuan945
Copy link

"prebuild-install":"^6.1.4" has a dependency 'node-abi':'^2.21.0', which does not get the electron node-abi version correctly
prebuild/prebuild-install#161 (comment)

electron/node-abi#113 was fixed in 3.3.0 and is affecting electron 14+

With the current node-abi prebuild-install will download ABI 89 for electron 14 and 15 and then modules will fail to load as electron 14 has ABI 97 and electon 15 has ABI 98 in reality.

@reconbot
Copy link
Member

This upgrade is a good idea but there's some bad hostnames in that lock file. Maybe you have custom registry?

@reconbot
Copy link
Member

I'll make this change and get it out.

@reconbot reconbot closed this Nov 26, 2021
@zixuan945
Copy link
Author

Yes, I did set up a custom registry. I 'm not familiar with lock file
Thank you for fixing this issue.

@reconbot
Copy link
Member

Released in serialport@9.2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants