Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move from serialport/node-serialport #2

Merged
merged 1 commit into from
Feb 5, 2022
Merged

Conversation

reconbot
Copy link
Member

@reconbot reconbot commented Feb 5, 2022

Move the mock binding code from the monorepo - where it is now unfortunately has it part of a circular dependency with bindings-cpp and binding-interface. To update the interface, you need to publish the interface, update the monorepo's binding-mock but not any other package, publish that (difficult or impossible because of how lerna works), update bindings-cpp and then update the rest of the packages in the monorepo.

With this move to a new repository;

  • update bindings-interface
  • update bindings-mock
  • update bindings-cpp
  • update the serialport monorepo

This is still way to many steps but at least it's possible.

You might be asking why we have a bindings-interface package at all? Because every binding that the monorepo supports needs to impliment the same bindings interface.

Why does bindings-cpp use bindings-mock? This is to ensure we have the same test suite passing for both bindings. It's not ideal but I'm not sure how we might separate it out. It's a holdover from when they were in the same monorepo.

@reconbot
Copy link
Member Author

reconbot commented Feb 5, 2022

This might be the case were just copying the same test suite to each package would help.

@reconbot reconbot merged commit aea1368 into main Feb 5, 2022
@reconbot reconbot deleted the reconbot/migration branch February 5, 2022 15:10
reconbot added a commit to serialport/node-serialport that referenced this pull request Feb 5, 2022
- fix stopbits definition to 1 | 1.5 | 2
- This also includes moving binding-mock to it's own repo for details on why this has to be done at the same time see serialport/binding-mock#2
reconbot added a commit to serialport/node-serialport that referenced this pull request Feb 5, 2022
- fix stopbits definition to 1 | 1.5 | 2
- This also includes moving binding-mock to it's own repo for details on why this has to be done at the same time see serialport/binding-mock#2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant