fix: move from serialport/node-serialport #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the mock binding code from the monorepo - where it is now unfortunately has it part of a circular dependency with
bindings-cpp
andbinding-interface
. To update the interface, you need to publish the interface, update the monorepo'sbinding-mock
but not any other package, publish that (difficult or impossible because of how lerna works), updatebindings-cpp
and then update the rest of the packages in the monorepo.With this move to a new repository;
bindings-interface
bindings-mock
bindings-cpp
This is still way to many steps but at least it's possible.
You might be asking why we have a
bindings-interface
package at all? Because every binding that the monorepo supports needs to impliment the same bindings interface.Why does
bindings-cpp
usebindings-mock
? This is to ensure we have the same test suite passing for both bindings. It's not ideal but I'm not sure how we might separate it out. It's a holdover from when they were in the same monorepo.