Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX ArgumentCountError in UploadController::saveMedia #625

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

The-MEO
Copy link
Contributor

@The-MEO The-MEO commented Jan 19, 2025

New code parameter from the commit be6a8cc1c1ecfe9489fb51e4869af15a13fc2cd2
needs an default value to work with php 7.1+ (https://www.php.net/manual/en/migration71.incompatible.php)

Uploading files in the browser with the docker image from https://github.com/linuxserver/docker-xbackbone version 3.8.0 is at the moment without this default value not possible.

The Error logfile was contained:

[2025-01-19 13:51:37] app.ERROR: Slim Application Error
Type: ArgumentCountError
Code: 0
Message: Too few arguments to function App\Controllers\UploadController::saveMedia(), 3 passed in /app/www/public/app/Controllers/UploadController.php on line 62 and exactly 4 expected
File: /app/www/public/app/Controllers/UploadController.php
Line: 186
Trace: #0 /app/www/public/app/Controllers/UploadController.php(62): App\Controllers\UploadController->saveMedia()
#1 [internal function]: App\Controllers\UploadController->uploadWeb()
#2 /app/www/public/vendor/php-di/invoker/src/Invoker.php(74): call_user_func_array()
#3 /app/www/public/vendor/php-di/slim-bridge/src/ControllerInvoker.php(45): Invoker\Invoker->call()
#4 /app/www/public/vendor/slim/slim/Slim/Routing/Route.php(384): DI\Bridge\Slim\ControllerInvoker->__invoke()
#5 /app/www/public/vendor/slim/slim/Slim/MiddlewareDispatcher.php(81): Slim\Routing\Route->handle()
#6 /app/www/public/app/Middleware/CheckForMaintenanceMiddleware.php(26): Slim\MiddlewareDispatcher->handle()
#7 /app/www/public/vendor/slim/slim/Slim/MiddlewareDispatcher.php(209): App\Middleware\CheckForMaintenanceMiddleware->__invoke()
#8 /app/www/public/app/Middleware/AuthMiddleware.php(33): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#9 /app/www/public/vendor/slim/slim/Slim/MiddlewareDispatcher.php(209): App\Middleware\AuthMiddleware->__invoke()
#10 /app/www/public/vendor/slim/slim/Slim/MiddlewareDispatcher.php(81): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#11 /app/www/public/vendor/slim/slim/Slim/Routing/Route.php(341): Slim\MiddlewareDispatcher->handle()
#12 /app/www/public/vendor/slim/slim/Slim/Routing/RouteRunner.php(84): Slim\Routing\Route->run()
#13 /app/www/public/app/Middleware/InjectMiddleware.php(21): Slim\Routing\RouteRunner->handle()
#14 /app/www/public/vendor/slim/slim/Slim/MiddlewareDispatcher.php(209): App\Middleware\InjectMiddleware->__invoke()
#15 /app/www/public/app/Middleware/LangMiddleware.php(25): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#16 /app/www/public/vendor/slim/slim/Slim/MiddlewareDispatcher.php(209): App\Middleware\LangMiddleware->__invoke()
#17 /app/www/public/app/Middleware/RememberMiddleware.php(39): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#18 /app/www/public/vendor/slim/slim/Slim/MiddlewareDispatcher.php(209): App\Middleware\RememberMiddleware->__invoke()
#19 /app/www/public/bootstrap/app.php(105): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#20 /app/www/public/vendor/slim/slim/Slim/MiddlewareDispatcher.php(313): Closure->{closure}()
#21 /app/www/public/vendor/slim/slim/Slim/Middleware/RoutingMiddleware.php(59): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#22 /app/www/public/vendor/slim/slim/Slim/MiddlewareDispatcher.php(147): Slim\Middleware\RoutingMiddleware->process()
#23 /app/www/public/vendor/slim/slim/Slim/Middleware/ErrorMiddleware.php(107): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#24 /app/www/public/vendor/slim/slim/Slim/MiddlewareDispatcher.php(147): Slim\Middleware\ErrorMiddleware->process()
#25 /app/www/public/vendor/slim/slim/Slim/MiddlewareDispatcher.php(81): Psr\Http\Server\RequestHandlerInterface@anonymous->handle()
#26 /app/www/public/vendor/slim/slim/Slim/App.php(215): Slim\MiddlewareDispatcher->handle()
#27 /app/www/public/vendor/slim/slim/Slim/App.php(199): Slim\App->handle()
#28 /app/www/public/index.php(11): Slim\App->run()
#29 {main}
Tips: To display error details in HTTP response set "displayErrorDetails" to true in the ErrorHandler constructor. [] []

New code parameter from the commit with
SHA: be6a8cc1c1ecfe9489fb51e4869af15a13fc2cd2
needs default value to work with php 7.1+ (https://www.php.net/manual/en/migration71.incompatible.php)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants