-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[joss] software paper comments #21
Comments
Hi @hbaniecki! It's been forever, I'm so sorry! I've moved to Switzerland and started working as a postdoctoral researcher here, and it was a huge change in my life. I've addressed most of the points you highlighted (commit 61c8419), btw THANKS for your valuable advices. Below I'll address each one of your points: Comments
Summary
Statement of need State of the field Implementation
Illustrative examples
Conclusions I'm still working on the changes regarding the "Statement of need", I'll let you know as soon as I finish with it. Again, thank you so much for your review work, and apologize for the delay.... |
openjournals/joss-reviews#3934 Hi, I hope these comments help in improving the paper.
Comments
1.0
of the package (on GitHub, PyPI) and mark that in the paper, e.g. in the Summary section.Summary
Statement of need
This part discusses mainly the need for open-source implementation of the machine learning models. However, as I see it, the significant contributions of the software/paper, distinguishing it from the previous work, are the
Live_Test
/Evaluation
tools allowing for visual explanation and hyperparameter optimization. This could be further underlined.State of the field
The paper lacks a brief discussion on packages in the field of interpretable and explainable machine learning. In that, I suggest the authors reference/compare to the following software related to interactive explainability:
Other possibly missing/useful references:
Implementation
scikit-learn
Illustrative examples
Dataset.load_from_url()
function.Conclusions
Again, I have doubts that the machine learning model is "novel", as it has been previously published etc.. It might be misunderstood as "introducing a novel machine learning model".
The text was updated successfully, but these errors were encountered: