Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on setuptools for pythran -E #2231

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

serge-sans-paille
Copy link
Owner

This should simplify the life of scipy maintainers, see #2228.

This one changed with recent numpy upgrade, see
numpy/numpy#26766
This makes the code more resilient to future numpy changes.
This should simplify the life of scipy maintainers, see #2228.
@serge-sans-paille
Copy link
Owner Author

serge-sans-paille commented Aug 22, 2024

@agriyakhetarpal / @rgommers is the last commit of this patchset enough for scipy? Do you need a minor release with it?

@agriyakhetarpal
Copy link

Hi @serge-sans-paille, I may not have the full context, but FWIW, since it reduces reliance on setuptools's functionality at least for building Pythran extension modules, it is a beneficial change that would be nice to incorporate in a new minor release – especially because source builds from SciPy releases were broken for an interim time period between setuptools version 73.0.0 and version 73.0.1.

@serge-sans-paille serge-sans-paille merged commit 0d06ab4 into master Aug 22, 2024
19 checks passed
@rgommers
Copy link
Contributor

Thanks @serge-sans-paille! This looks like it does the job indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants