hotfix: address metaclass definition in PythranBuildExt
#2230
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm not sure if this is the best fix for #2228 or if this is something that should be resolved in
setuptools
instead, but this PR is a small fix that resolves the metaclass conflict in Pythran that is coming fromsetuptools
's new v73.0.0 release. I can close this PR if it gets resolved elsewhere!The test suite is running on my fork here: agriyakhetarpal#1 and I have verified that the fix works by running a few of the tests locally with both setuptools>=73 and setuptools<73 (the tests do take some time to fire away, though!), and in the meantime, #2229 pins
setuptools
to <73 which is an easier fix to incorporate.Changes made
PythranBuildExtMeta
derives fromtype(LegacyBuildExt)
– which ensures thatPythranBuildExtMeta
is a subclass of the metaclass used byLegacyBuildExt
, and__getitem__
method, it now uses thetype()
function to dynamically construct a new class.Additional context
xref to some downstream issues where this was discovered: