Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Eq (and PartialEq) for ActivityData #3094

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Implement Eq (and PartialEq) for ActivityData #3094

merged 1 commit into from
Jan 15, 2025

Conversation

valentinegb
Copy link
Contributor

Allows two ActivityDatas to be compared for equality. (For instance, my use case, checking if an ActivityData randomly selected from an array is equal to an ActivityData that was previously selected.)

@github-actions github-actions bot added the gateway Related to the `gateway` module. label Jan 15, 2025
@arqunis arqunis added the enhancement An improvement to Serenity. label Jan 15, 2025
@arqunis arqunis merged commit 5f2133e into serenity-rs:current Jan 15, 2025
22 checks passed
@valentinegb valentinegb deleted the activitydata-eq branch January 15, 2025 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
enhancement An improvement to Serenity. gateway Related to the `gateway` module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinegb @arqunis