Encapsulate Message Cache in it's own type #3065
Draft
+187
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
model
GnomedDev
added
the
needs-testing
GnomedDev
force-pushed
the
encapsulate-message-cache
branch
from
fc40056 to
9cd15a5
Compare
github-actions
bot
removed
model
GnomedDev
force-pushed
the
encapsulate-message-cache
branch
from
921d17e to
dafd4bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft as based on #3061.
This keeps the invariant (channel ordering and max messages setting) encapsulated and correctly handled, while speeding up message create handling and pushing messages into the cache from edits.