Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide youtube-dlc as an alternative to youtube-dl #1076

Closed
wants to merge 4 commits into from
Closed

Provide youtube-dlc as an alternative to youtube-dl #1076

wants to merge 4 commits into from

Conversation

peppizza
Copy link
Contributor

youtube-dl's progress has slowed down and will very often error with ERROR: Unable to extract JS player URL. youtube-dlc is a drop-in replacement for youtube-dl that is being updated and does not have that error https://github.com/blackjack4494/yt-dlc

@vicky5124
Copy link
Contributor

this could probably be made into a feature, to let users choose between either one, and not make this a breaking change.
youtube-dl is more accessible as it's available on most linux package managers, so it's support should stay.

@peppizza
Copy link
Contributor Author

maybe, however the error that i posted above is very frequent with youtube-dl and it's not clear to a user of the library what the issue is

@vicky5124
Copy link
Contributor

it could be mentioned in a documentation line, as a note

@peppizza
Copy link
Contributor Author

youtube-dl and youtube-dlc are now both features with youtube-dlc being the default

@Flat
Copy link
Member

Flat commented Nov 13, 2020

As the tried and tested program youtube-dl should probably be the default. Claims that youtube-dlc is more maintained would also need some further information.

@Lakelezz
Copy link
Contributor

Lakelezz commented Nov 13, 2020

I do agree that youtube-dl should stay our default for now, suddenly changing the default to a new fork sounds adventurous.

@arqunis arqunis added dependencies Related to Serenity dependencies. enhancement An improvement to Serenity. voice Related to the `voice` module and `serenity_voice_model` crate. labels Nov 13, 2020
@peppizza peppizza changed the title switch to youtube-dlc Provide youtube-dlc as an alternative to youtube-dl Nov 13, 2020
@peppizza
Copy link
Contributor Author

youtube-dl is now the default feature and I updated the compile_error message to reflect it

@peppizza
Copy link
Contributor Author

moving to https://github.com/serenity-rs/songbird

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related to Serenity dependencies. enhancement An improvement to Serenity. voice Related to the `voice` module and `serenity_voice_model` crate.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants