Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat task 0510 developments #1357

Merged
merged 6 commits into from
Oct 5, 2024
Merged

Feat task 0510 developments #1357

merged 6 commits into from
Oct 5, 2024

Conversation

serengil
Copy link
Owner

@serengil serengil commented Oct 5, 2024

Tickets

Resolves #1331, #1336 and #1347

What has been done

With this PR, we covered these enhancements:

  • retinaface detector returns nose and mouth coordinates. these are returned now in extract faces.
  • we stored the source urls of weights in a global dictionary to help developers who want to download them all in one shot
  • when VGG-Face is built, an unused sequantial layer was created, we got rid of it.

How to test

make lint && make test

@serengil serengil merged commit 5415407 into master Oct 5, 2024
4 checks passed
@serengil serengil deleted the feat-task-0510-developments branch October 5, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: ValueError: The layer sequential has never been called and thus has no defined input.
1 participant