Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet should check destination address before asking additional questions #43

Closed
KarboDuck opened this issue Jan 14, 2021 · 0 comments
Closed

Wallet should check destination address before asking additional questions #43

KarboDuck opened this issue Jan 14, 2021 · 0 comments
Labels
bug

Comments

@KarboDuck
Copy link

KarboDuck commented Jan 14, 2021 •
edited
Loading

  1. On send tab specifically don't fill "Pay To:" field.
  2. Press send.

Result:
Wallets asks two questions:

  1. the password
  2. and if you want to send without payment id

And only after that shows warning "Invalid recepient address"

Expected:
Warning about invalid/empty address before asking for password and payment id.

Probably instead of modal dialog with error just highlight "Pay To" field with red color blink, or something.
@KarboDuck KarboDuck changed the title Checkin Wallet should check destination address before asking additional questions Jan 14, 2021
@KarboDuck KarboDuck mentioned this issue Jan 14, 2021
Closed
@aivve aivve added the bug label Jan 15, 2021
@aivve aivve closed this as completed in f8fbed7 Jan 15, 2021
aivve added a commit to Karbovanets/karbowanecwallet that referenced this issue Jan 15, 2021
@aivve
Show error messages when address or amount is invalid prior to confir…
d38f856 
…m dialogue in Send, fixes seredat#43, seredat#44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aivve @KarboDuck