Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deserializing invalid UTF-8 into bytes in maps #856

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scrblue
Copy link

@scrblue scrblue commented Jan 25, 2022

Simple fix for #855.

@scrblue
Copy link
Author

scrblue commented Feb 1, 2022

Seems like I forgot to check the tests with all features, sorry. In any case the test fails because it's expecting an error when deserializing into a Value where now bytes are supported in place of Strings when the data isn't valid UTF-8.

What functionality would be correct here? I don't think supporting non-UTF-8 strings is a bad choice (although I'm biased), especially since they're supported explicitly elsewhere, but I'm unsure if anyone deserializing directly into a Value depends on non-UTF-8 throwing an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant