Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In situ parsing WIP #627

Closed
wants to merge 1 commit into from
Closed

In situ parsing WIP #627

wants to merge 1 commit into from

Conversation

pickfire
Copy link

@pickfire pickfire commented Mar 2, 2020

dtolnay/request-for-implementation#7

I believe it would be better to make this function unsafe since it would be undefined behavior if they tried to call this function twice on the same data unless we can somehow make sure they do not call it twice. Pending tasks:

  • remove unused benchmark
  • remove fuzz tests (not sure if useful later)
  • make function unsafe (needs discussion)
  • update docs
  • rearrange tests

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a promising start.

I'll close the PR because I'm not interested in accepting this functionality in serde_json just yet. I would prefer if this were published as a separate crate -- that's why it was filed in request-for-implementation instead of an issue here.

Thanks anyway!

@dtolnay dtolnay closed this Mar 15, 2020
@pickfire pickfire deleted the in-situ branch March 16, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants