-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Arbitrary precision numbers #252
Conversation
@alexreg please take a quick look at this and let us know whether it satisfies your use case. |
A few name changes I would suggest for clarity/consistency:
Take them or leave them. :) |
Thanks for the idea. I would prefer to leave it as is. We use |
Waiting on #18 (comment). |
Fair enough. |
I am going to try to rework this to use the same trick that TOML uses for specialized handling of Datetimes without relying on specialization. |
If it's using a "trick", I'd be very much against that! Nothing too hacky, please. |
Let's call it "under-explored abilities of the API" rather than "trick." |
Okay. I quite like the way it worked currently... so I hope it doesn't change too much! |
Any update on this yet, @dtolnay? |
Nope, will be post 1.0. |
Okay. No chance of getting a feature-gated specialisation-based version before then? I don't know when 1.0 will be, but I guess soon-ish... |
No chance of getting a feature-gated specialization-based version. We are making some lifetime-related changes in the next release (#288) and specialization interacts very poorly with lifetimes - use after free, corrupted data, etc. See rust-lang/rust#40582. |
@dtolnay How about now? :) |
… feature). This effort was based in part on the work of @dtolnay in serde-rs#252 and @alexcrichton in https://github.com/alexcrichton/toml-rs. Also updated test suite for `arbitrary_precision` feature.
… feature). This effort was based in part on the work of @dtolnay in serde-rs#252 and @alexcrichton in https://github.com/alexcrichton/toml-rs. Also updated test suite for `arbitrary_precision` feature.
Fixes #18.