Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For embedded use cases, instead of
alloc
it's often preferable to useheapless
: fixed-capacity strings and vectors. This patch would allow serializingVec<u8>
as byte strings instead of generic vectors.A minimal example: https://github.com/nickray/serde-bytes-heapless-test/blob/master/src/lib.rs
I think it would be nice to have this patch here, would that make sense? The alternative being
heapless
having aBytes
type itself (rust-embedded/heapless#138).Regarding tests, I'm not sure how they could be added.
Regarding error handling, I'm not sure if or how to map capacity errors when deserializing instead of horribly panicking.