New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for compatibility with new gRPC target interface #36

Merged

sercand merged 1 commit into sercand:master from wyattanderson:v4

Mar 13, 2023

Contributor

wyattanderson commented Feb 28, 2023

Upgrades to a newer version of google.golang.org/grpc that includes breaking changes to the resolver.Target type (see Cleanup usages of resolver.Target.Endpoint grpc/grpc-go#5796)
Reworks and hopefully simplifies target parsing code, given that now all targets must be valid RFC 3986 URLs (see grpc: better RFC 3986 compliant target parsing grpc/grpc-go#4817)
Updates tests accordingly.

Tested locally by running go test after forwarding to my local K8s cluster with kubectl --context docker-desktop proxy --port 8001.


          Updates for compatibility with new gRPC target interface

d8a3bdc

wyattanderson mentioned this pull request

Fix a BC introduced in latest version of grpc #35

Closed

dannyskoog mentioned this pull request

Not work with grpc v1.53.0 #34

Closed

sercand merged commit 7d3b484 into sercand:master

sercand mentioned this pull request

Update to work with grpc 1.53 #37

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet