DKG Removals #467
Merged
DKG Removals #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implementation is via a new publish_tributary_tx lambda. This is code is a copy-pasted mess which will need to be cleaned up.
Otherwise, it's risked that the remaining validators fall below 67% of the original set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pros:
Cons:
The immediate next step is to refactor the coordinator to de-duplicate common code which was not done in this PR in order to prevent scope creep and cleanly delineate the new logic introduced here. Having reviewed the diff, I can confirm it's sane and sufficiently clean, even if I was miserable implementing it.
As for testing, Serai will likely end up testing success paths prior to testnet, testing all paths during the testnet in order to run our work in parallel and not be unnecessarily blocked.
Once CI passes, will merge.