Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add db:create and db:drop for MySQL/Postgres 🎊 #510

Closed
wants to merge 1 commit into from

Conversation

aledalgrande
Copy link

@aledalgrande aledalgrande commented Aug 9, 2017

Needed for a better dev experience. I didn't use sequelize because it doesn't have support for opening a connection without a database, but the dialect libraries work.

Feel free to request any changes.

Solves #70.

@mention-bot
Copy link

@aledalgrande, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Americas, @leebenson and @fossamagna to be potential reviewers.

@dagumak
Copy link

dagumak commented Aug 25, 2017

I was surprised to find that this was missing! @eseliger Thoughts?

@dagumak
Copy link

dagumak commented Aug 25, 2017

@aledalgrande

$ sequelize db:create

Sequelize [Node: 7.7.3, CLI: 2.8.0, ORM: 4.7.5]

Loaded configuration file "config/config.json".
Using environment "development".
{ Error: Cannot find module 'pg'

Edit: I see what happened here. Since you're using the pg gem here and the CLI is in my global, I had to install pg in the global as well.

var client = new Postgres({
user: config.username,
host: config.host,
database: 'postgres',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config.database?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dagumak nope, I am passing postgres because the database doesn't exist yet, so I am using the default one.

codetriage-readme-bot pushed a commit to codetriage-readme-bot/cli that referenced this pull request Jun 5, 2019
…eases

bin: add freebsd and openbsd releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants