Adds the argument --es6 in the command migration:create and seed:create #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option will generate a skeleton file in es6 format.
Since there is a converter from js to coffee, it is assumed that a file would be generated in es6 and then converted to coffee. So... When both args are used, the es6 is ignored.
|
I've just realized that there is another skeleton for Well... I'll work on this to support |
|
What does OBS stand for? |
|
Observation Where I live, it's a common word to use when you want to write something that the reader must pay attention. I didn't know it wasn't usual outside my country. |
|
Ah, I was trying not to assume anything. I’m also new to Open Source and I didn’t know if it was something specific to the project or not.
- James
… On Jul 28, 2017, at 7:29 AM, Felipe de Alencar Pinheiro ***@***.***> wrote:
Observation
Where I live, it's a common word to use when you want to write something that the reader must pay attention. I didn't know it wasn't usual outside my country.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub <#493 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABzr9LR3TET6hPu9inxeJSHghP3kDcjWks5sSfBbgaJpZM4Okyti>.
|
felpin
changed the title
|
Does anyone know how to run CI again? The check has failed because |
|
Fixed in 733ced9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of the PR is to add the option
--es6to the commandmigration:create.When executing
migration:create --es6it will use a skeleton in ES6 format with arrow functions.This PR resolves issue #482, although it is not a breaking change required for major version. Maybe a future PR can change the default skeleton to be in ES6 format.
This PR may resolve issue #389 if it is a duplicate from #482.
OBS: When executing
migration:create --es6 --coffee, the argument--es6will be ignored. The reason is that the js file would be converted to a coffee file. 'Would' is the correct word here because js2coffee doesn't support ES6 yet (See issue)